Page MenuHomePhabricator

Cleanup leftover phononactivationtime option
ClosedPublic

Authored by jasonbcox on Jul 1 2020, 23:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc931b3d676ed: Cleanup leftover phononactivationtime option
Summary

Normally, post-upgrade we would replace Params.phononActivationTime
with Params.phononHeight similar to what we did with the Graviton upgrade.
However, doing so breaks the abc-miner-fund.py functional test. There is some
value to keeping the that test maintained until it's clear we will not need it
in this coming upgrade feature freeze. At that point, we can remove the test
and use phononHeight.

Cleaning up the unused runtime option gets rid of some kruft today and ensures
the patch for phononHeight will be minimal.

Test Plan

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.