Page MenuHomePhabricator

[backport#13910] Log progress while verifying blocks at level 4
ClosedPublic

Authored by majcosta on Jul 8 2020, 01:58.

Details

Summary

e58985c916 Log progress while verifying blocks at level 4. (Daniel Kraft)

Pull request description:

When verifying blocks at startup, the progress is printed in 10% increments to logs.  When `-checklevel=4`, however, the second half of the verification (connecting the blocks again) does not log the progress anymore.  (It is still computed and shown in the UI, but not printed to logs.)

This change makes the behaviour consistent, by adding the missing progress logging also for level-4 checks.

Backport of Core PR13910

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Jul 8 2020, 01:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Jul 8 2020, 09:30
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
4705 ↗(On Diff #22069)

c++ constructors

4707 ↗(On Diff #22069)

Dito

4711 ↗(On Diff #22069)

The /* Continued */ is redundant here

This revision now requires changes to proceed.Jul 8 2020, 09:30

replaced old-style casts with constructor-style casts

This revision is now accepted and ready to land.Jul 8 2020, 17:54
This revision was landed with ongoing or failed builds.Jul 8 2020, 18:23
This revision was automatically updated to reflect the committed changes.