Page MenuHomePhabricator
Differential D6870

[secp256k1] Do not use unitialized multiset in multiset benchmark
ClosedPublic
Actions

Authored by deadalnix on Jul 9 2020, 10:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC540d25abdcb7: [secp256k1] Do not use unitialized multiset in multiset benchmark
Summary

As per title.

The compiler might possibly collapse everything based on the fact x is uninitialized, which we do not want.

Test Plan
ninja bench-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 9 2020, 10:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2020, 10:55
deadalnix requested review of this revision.Jul 9 2020, 10:55
Fabien accepted this revision.Jul 9 2020, 11:00
This revision is now accepted and ready to land.Jul 9 2020, 11:00
This revision was landed with ongoing or failed builds.Jul 9 2020, 11:04
Closed by commit rABC540d25abdcb7: [secp256k1] Do not use unitialized multiset in multiset benchmark (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC540d25abdcb7: [secp256k1] Do not use unitialized multiset in multiset benchmark.
Harbormaster completed remote builds in B11921: Diff 22110.Jul 9 2020, 11:11

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
4 lines

Diff 22111

View Options

src/secp256k1/src/bench_multiset.c

Loading...