Page MenuHomePhabricator
Differential D6922

[avalanche] Do not add invalid proof in PeerManager
ClosedPublic
Actions

Authored by deadalnix on Jul 13 2020, 18:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC228156f14092: [avalanche] Do not add invalid proof in PeerManager
Summary

As per title.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 13 2020, 18:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 13 2020, 18:08
deadalnix requested review of this revision.Jul 13 2020, 18:08
Harbormaster completed remote builds in B11988: Diff 22229.Jul 13 2020, 18:24
Fabien accepted this revision.Jul 13 2020, 18:40
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/proof.cpp
7 ↗(On Diff #22229)

Nit: one => once

This revision is now accepted and ready to land.Jul 13 2020, 18:40
Closed by commit rABC228156f14092: [avalanche] Do not add invalid proof in PeerManager (authored by deadalnix). · Explain WhyJul 13 2020, 18:46
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC228156f14092: [avalanche] Do not add invalid proof in PeerManager.

Revision Contents
Changeset List

PathSize
src/
avalanche/
9 lines
6 lines
12 lines
test/
15 lines

Diff 22235

View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/proofbuilder.h

Loading...
View Options

src/avalanche/proofbuilder.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...