Page MenuHomePhabricator
Differential D6932

[backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck
ClosedPublic
Actions

Authored by majcosta on Jul 14 2020, 22:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfddb00fc8ce1: [backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in…
Summary

3a131b724 Rename out to m_tx_out in CScriptCheck (Johnson Lau)
e91211878 [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck (Johnson Lau)

Pull request description:

This simplifies CScriptCheck by combining scriptPubKey and amount

Backport of Core PR10953

Test Plan
ninja check && ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 14 2020, 22:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2020, 22:07
majcosta requested review of this revision.Jul 14 2020, 22:07
teamcity edited the summary of this revision. (Show Details)Jul 14 2020, 22:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12006: Diff 22267.Jul 14 2020, 22:23
Fabien accepted this revision.Jul 15 2020, 07:00
This revision is now accepted and ready to land.Jul 15 2020, 07:00
Closed by commit rABCfddb00fc8ce1: [backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in… (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJul 15 2020, 14:52
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCfddb00fc8ce1: [backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in….

Revision Contents
Changeset List

PathSize
src/
test/
12 lines
3 lines
18 lines
14 lines

Diff 22273

View Options

src/test/script_p2sh_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...