Page MenuHomePhabricator
Differential D6957

[backport#15040] Add workaround for QProgressDialog bug on macOS
ClosedPublic
Actions

Authored by majcosta on Jul 16 2020, 21:42.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC93424b164732: [backport#15040] Add workaround for QProgressDialog bug on macOS
Summary

See: QTBUG-65750, QTBUG-70357.

Backport of Core PR15040

This apparently reapplies a nit fixed in D2144. I've chosen to stay close to the Core version for less merge headaches.

Test Plan

unfortunately I do not have a macOS in hand to test this

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 16 2020, 21:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2020, 21:42
majcosta requested review of this revision.Jul 16 2020, 21:42
teamcity edited the summary of this revision. (Show Details)Jul 16 2020, 21:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12036: Diff 22320.Jul 16 2020, 21:59
jasonbcox accepted this revision.Jul 16 2020, 22:20
This revision is now accepted and ready to land.Jul 16 2020, 22:20
Closed by commit rABC93424b164732: [backport#15040] Add workaround for QProgressDialog bug on macOS (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by majcosta). · Explain WhyJul 16 2020, 22:47
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC93424b164732: [backport#15040] Add workaround for QProgressDialog bug on macOS.

Revision Contents
Changeset List

PathSize
src/
qt/
12 lines
4 lines
13 lines
4 lines

Diff 22324

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/walletview.cpp

Loading...