Page MenuHomePhabricator
Differential D7044

[backport#16745] wallet: Translate all initErrors in CreateWalletFromFile
ClosedPublic
Actions

Authored by majcosta on Jul 27 2020, 16:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC78c5f12b9ff1: [backport#16745] wallet: Translate all initErrors in CreateWalletFromFile
Summary

wallet: Translate all initErrors in CreateWalletFromFile (MarcoFalke)
util: Make util/error bilingual_str (refactor) (MarcoFalke)

Pull request description:

The translations are going to close in three days (#15940), so I am submitting this as a standalone pull request.

Those changes are part of a bugfix #16661, which includes a test. The first change (the refactor) is required, the second commit is not. I am happy to drop it, if needed.

https://github.com/bitcoin/bitcoin/pull/16745/files

Backport of Core PR16745

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 27 2020, 16:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2020, 16:57
majcosta requested review of this revision.Jul 27 2020, 16:57
Harbormaster completed remote builds in B12170: Diff 22531.Jul 27 2020, 17:03
teamcity added a comment.Jul 27 2020, 17:03
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

interface_rest.py                       | ○ Skipped | 0 s
mempool_accept.py                       | ○ Skipped | 0 s
mempool_limit.py                        | ○ Skipped | 0 s
mempool_packages.py                     | ○ Skipped | 0 s
mempool_persist.py                      | ○ Skipped | 0 s
mempool_reorg.py                        | ○ Skipped | 0 s
mempool_resurrect.py                    | ○ Skipped | 0 s
mempool_spend_coinbase.py               | ○ Skipped | 0 s
mining_prioritisetransaction.py         | ○ Skipped | 0 s
p2p_compactblocks.py                    | ○ Skipped | 0 s
p2p_feefilter.py                        | ○ Skipped | 0 s
p2p_leak_tx.py                          | ○ Skipped | 0 s
rpc_createmultisig.py                   | ○ Skipped | 0 s
rpc_estimatefee.py                      | ○ Skipped | 0 s
rpc_psbt.py                             | ○ Skipped | 0 s
rpc_scantxoutset.py                     | ○ Skipped | 0 s
rpc_signmessage.py                      | ○ Skipped | 0 s
rpc_signrawtransaction.py               | ○ Skipped | 0 s
rpc_txoutproof.py                       | ○ Skipped | 0 s
tool_wallet.py                          | ○ Skipped | 0 s
wallet_abandonconflict.py               | ○ Skipped | 0 s
wallet_address_types.py                 | ○ Skipped | 0 s
wallet_avoidreuse.py                    | ○ Skipped | 0 s
wallet_backup.py                        | ○ Skipped | 0 s
wallet_balance.py                       | ○ Skipped | 0 s
wallet_basic.py                         | ○ Skipped | 0 s
wallet_create_tx.py                     | ○ Skipped | 0 s
wallet_createwallet.py                  | ○ Skipped | 0 s
wallet_createwallet.py --usecli         | ○ Skipped | 0 s
wallet_dump.py                          | ○ Skipped | 0 s
wallet_encryption.py                    | ○ Skipped | 0 s
wallet_groups.py                        | ○ Skipped | 0 s
wallet_hd.py                            | ○ Skipped | 0 s
wallet_import_rescan.py                 | ○ Skipped | 0 s
wallet_import_with_label.py             | ○ Skipped | 0 s
wallet_importmulti.py                   | ○ Skipped | 0 s
wallet_importprunedfunds.py             | ○ Skipped | 0 s
wallet_keypool.py                       | ○ Skipped | 0 s
wallet_keypool_topup.py                 | ○ Skipped | 0 s
wallet_labels.py                        | ○ Skipped | 0 s
wallet_listreceivedby.py                | ○ Skipped | 0 s
wallet_listsinceblock.py                | ○ Skipped | 0 s
wallet_listtransactions.py              | ○ Skipped | 0 s
wallet_multiwallet.py                   | ○ Skipped | 0 s
wallet_multiwallet.py --usecli          | ○ Skipped | 0 s
wallet_resendwallettransactions.py      | ○ Skipped | 0 s
wallet_txn_clone.py                     | ○ Skipped | 0 s
wallet_txn_clone.py --mineblock         | ○ Skipped | 0 s
wallet_txn_doublespend.py               | ○ Skipped | 0 s
wallet_txn_doublespend.py --mineblock   | ○ Skipped | 0 s
wallet_zapwallettxes.py                 | ○ Skipped | 0 s
interface_zmq.py                        | ✖ Failed  | 62 s

ALL                                     | ✖ Failed  | 307 s (accumulated) 
Runtime: 70 s

FAILED: test/CMakeFiles/check-functional 
cd /work/abc-ci-builds/build-without-wallet/test && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py
ninja: build stopped: subcommand failed.
Build build-without-wallet failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: interface_zmq.py

Fabien added a subscriber: Fabien.Jul 27 2020, 21:29

@bot build-without-wallet

Fabien accepted this revision.Jul 27 2020, 21:46
This revision is now accepted and ready to land.Jul 27 2020, 21:46
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Closed by commit rABC78c5f12b9ff1: [backport#16745] wallet: Translate all initErrors in CreateWalletFromFile (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyJul 28 2020, 07:18
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC78c5f12b9ff1: [backport#16745] wallet: Translate all initErrors in CreateWalletFromFile.

Revision Contents
Changeset List

PathSize
src/
16 lines
util/
8 lines
12 lines
wallet/
17 lines

Diff 22561

View Options

src/init.cpp

Loading...
View Options

src/util/error.h

Loading...
View Options

src/util/error.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...