Page MenuHomePhabricator

[backport#14465] tests: Stop node before removing the notification file
ClosedPublic

Authored by majcosta on Wed, Jul 29, 16:45.

Details

Summary

Stop node before removing the notification file (Chun Kuan Lee)

Pull request description:

Stop node before removing the notification file to make sure the command has been terminated. After then we could removing those files safely and do not receive any permission error. (See #14446)

The permission error is Windows specific, documented in python doc:
>On Windows, attempting to remove a file that is in use causes an exception to be raised

See https://docs.python.org/3/library/os.html#os.remove

https://github.com/bitcoin/bitcoin/pull/14465/commits/ca6d86c3221fbeab63f451e1fb901a68d2c4a1aa


Backport of Core PR14465

Test Plan
ninja
test_runner.py feature_notifications

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Wed, Jul 29, 16:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jul 29, 16:45
majcosta requested review of this revision.Wed, Jul 29, 16:45
teamcity edited the summary of this revision. (Show Details)Wed, Jul 29, 16:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Wed, Jul 29, 20:30
This revision is now accepted and ready to land.Wed, Jul 29, 20:30