Differential D7089

[GITIAN] Stop distributing the *-unsigned.tar.gz archive
ClosedPublic
Actions

Authored by Fabien on Jul 30 2020, 14:37.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC31b5e2792846: [GITIAN] Stop distributing the *-unsigned.tar.gz archive

Summary

This archive used to contain the installer for both win32 and win64 in a
single archive. Now that there is no win32 anymore it is just an archive
of the installer that offer no additional compression and can just be
removed.

Test Plan

Run the windows Gitian build and check the archive is no longer part of
the output.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 30 2020, 14:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 30 2020, 14:37

Fabien requested review of this revision.Jul 30 2020, 14:37

Harbormaster completed remote builds in B12245: Diff 22642.Jul 30 2020, 15:01

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[0m[0;32mrpc_deriveaddresses.py --usecli         | ✓ Passed  | 2 s
[0m[0;32mrpc_estimatefee.py                      | ✓ Passed  | 2 s
[0m[0;32mrpc_getblockfilter.py                   | ✓ Passed  | 2 s
[0m[0;32mrpc_getblockstats.py                    | ✓ Passed  | 2 s
[0m[0;32mrpc_getchaintips.py                     | ✓ Passed  | 2 s
[0m[0;32mrpc_help.py                             | ✓ Passed  | 2 s
[0m[0;32mrpc_invalidateblock.py                  | ✓ Passed  | 6 s
[0m[0;32mrpc_misc.py                             | ✓ Passed  | 2 s
[0m[0;32mrpc_named_arguments.py                  | ✓ Passed  | 2 s
[0m[0;32mrpc_net.py                              | ✓ Passed  | 2 s
[0m[0;32mrpc_preciousblock.py                    | ✓ Passed  | 2 s
[0m[0;32mrpc_psbt.py                             | ✓ Passed  | 19 s
[0m[0;32mrpc_scantxoutset.py                     | ✓ Passed  | 6 s
[0m[0;32mrpc_setban.py                           | ✓ Passed  | 3 s
[0m[0;32mrpc_signmessage.py                      | ✓ Passed  | 2 s
[0m[0;32mrpc_signrawtransaction.py               | ✓ Passed  | 3 s
[0m[0;32mrpc_txoutproof.py                       | ✓ Passed  | 3 s
[0m[0;32mrpc_uptime.py                           | ✓ Passed  | 1 s
[0m[0;32mrpc_users.py                            | ✓ Passed  | 3 s
[0m[0;32mrpc_whitelist.py                        | ✓ Passed  | 1 s
[0m[0;32mtool_wallet.py                          | ✓ Passed  | 5 s
[0m[0;32mwallet_abandonconflict.py               | ✓ Passed  | 5 s
[0m[0;32mwallet_address_types.py                 | ✓ Passed  | 16 s
[0m[0;32mwallet_avoidreuse.py                    | ✓ Passed  | 2 s
[0m[0;32mwallet_backup.py                        | ✓ Passed  | 55 s
[0m[0;32mwallet_balance.py                       | ✓ Passed  | 12 s
[0m[0;32mwallet_basic.py                         | ✓ Passed  | 25 s
[0m[0;32mwallet_create_tx.py                     | ✓ Passed  | 12 s
[0m[0;32mwallet_createwallet.py                  | ✓ Passed  | 4 s
[0m[0;32mwallet_createwallet.py --usecli         | ✓ Passed  | 4 s
[0m[0;32mwallet_disable.py                       | ✓ Passed  | 1 s
[0m[0;32mwallet_dump.py                          | ✓ Passed  | 3 s
[0m[0;32mwallet_encryption.py                    | ✓ Passed  | 5 s
[0m[0;32mwallet_groups.py                        | ✓ Passed  | 14 s
[0m[0;32mwallet_hd.py                            | ✓ Passed  | 7 s
[0m[0;32mwallet_import_rescan.py                 | ✓ Passed  | 7 s
[0m[0;32mwallet_import_with_label.py             | ✓ Passed  | 2 s
[0m[0;32mwallet_importmulti.py                   | ✓ Passed  | 4 s
[0m[0;32mwallet_importprunedfunds.py             | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                       | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                 | ✓ Passed  | 5 s
[0m[0;32mwallet_labels.py                        | ✓ Passed  | 6 s
[0m[0;32mwallet_listreceivedby.py                | ✓ Passed  | 21 s
[0m[0;32mwallet_listsinceblock.py                | ✓ Passed  | 4 s
[0m[0;32mwallet_listtransactions.py              | ✓ Passed  | 23 s
[0m[0;32mwallet_multiwallet.py                   | ✓ Passed  | 17 s
[0m[0;32mwallet_multiwallet.py --usecli          | ✓ Passed  | 19 s
[0m[0;32mwallet_reorgsrestore.py                 | ✓ Passed  | 4 s
[0m[0;32mwallet_resendwallettransactions.py      | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_clone.py                     | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_clone.py --mineblock         | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_doublespend.py               | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_doublespend.py --mineblock   | ✓ Passed  | 5 s
[0m[0;32mwallet_zapwallettxes.py                 | ✓ Passed  | 5 s
[0m[1m
ALL                                     | ✓ Passed  | 870 s (accumulated) 
[0mRuntime: 176 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: mempool_accept.py

jasonbcox accepted this revision.Jul 30 2020, 17:09

This revision is now accepted and ready to land.Jul 30 2020, 17:09

This revision was landed with ongoing or failed builds.Jul 31 2020, 08:57

Closed by commit rABC31b5e2792846: [GITIAN] Stop distributing the *-unsigned.tar.gz archive (authored by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC31b5e2792846: [GITIAN] Stop distributing the *-unsigned.tar.gz archive.