Page MenuHomePhabricator
Differential D7229

build: Skip i686 build by default in gitian
ClosedPublic
Actions

Authored by Fabien on Aug 20 2020, 19:47.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC32bbcb69bd36: build: Skip i686 build by default in gitian
Summary

Backport of core PR18104.

From the PR conversation, it is made clear that nobody really uses the
shipped binary for 32 bits linux. We can safely stop distributing it as
part of our release process, but still make it possible to build from
source if desired. The build is now tested on CI to prevent from
regression.

Test Plan

Run the Gitian Linux build.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 20 2020, 19:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 20 2020, 19:47
Fabien requested review of this revision.Aug 20 2020, 19:47
teamcity edited the summary of this revision. (Show Details)Aug 20 2020, 19:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien added a comment.Aug 20 2020, 19:50

@bot gitian-linux

jasonbcox requested changes to this revision.Aug 20 2020, 20:27
jasonbcox added a subscriber: jasonbcox.

Also remove i686 from contrib/release/github-release.sh

This revision now requires changes to proceed.Aug 20 2020, 20:27
Harbormaster completed remote builds in B12437: Diff 22986.Aug 20 2020, 20:35
Fabien updated this revision to Diff 22990.Aug 20 2020, 21:33

Remove also from github-release.sh

jasonbcox accepted this revision.Aug 20 2020, 21:59
This revision is now accepted and ready to land.Aug 20 2020, 21:59
Harbormaster completed remote builds in B12440: Diff 22990.Aug 20 2020, 22:01
Closed by commit rABC32bbcb69bd36: build: Skip i686 build by default in gitian (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyAug 20 2020, 22:25
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC32bbcb69bd36: build: Skip i686 build by default in gitian.

Revision Contents
Changeset List

PathSize
contrib/
gitian-descriptors/
7 lines
release/
1 line

Diff 22995

View Options

contrib/gitian-descriptors/gitian-linux.yml

Loading...
View Options

contrib/release/github-release.sh

Loading...