Page MenuHomePhabricator
Differential D7255

[CMAKE] Flag the HTML man pages as generated
ClosedPublic
Actions

Authored by Fabien on Aug 26 2020, 14:24.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC36a137772cfe: [CMAKE] Flag the HTML man pages as generated
Summary

This prevent them from being shown by default during reviews.
Follow-up for feedback from D7252.

Test Plan
ninja install-manpages-html

Check the @generated marker is present in the files

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 26 2020, 14:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2020, 14:24
Fabien requested review of this revision.Aug 26 2020, 14:24
Harbormaster completed remote builds in B12473: Diff 23045.Aug 26 2020, 14:53
deadalnix requested changes to this revision.Aug 26 2020, 15:26
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
cmake/templates/man2html.sh.in
32 ↗(On Diff #23045)

Shouldn't this be in the header instead?

This revision now requires changes to proceed.Aug 26 2020, 15:26
Fabien requested review of this revision.Aug 26 2020, 15:52
Fabien added inline comments.
cmake/templates/man2html.sh.in
32 ↗(On Diff #23045)

I tried it first but that made jekyll skip the files for some reason

deadalnix accepted this revision.Aug 26 2020, 15:53
This revision is now accepted and ready to land.Aug 26 2020, 15:53
Closed by commit rABC36a137772cfe: [CMAKE] Flag the HTML man pages as generated (authored by Fabien). · Explain WhyAug 26 2020, 18:16
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC36a137772cfe: [CMAKE] Flag the HTML man pages as generated.

Revision Contents
Changeset List

PathSize
cmake/
templates/

Diff 23050

View Options

cmake/templates/man2html.sh.in

Loading...