Page MenuHomePhabricator

[backport#14890] rpc: Avoid creating non-standard raw transactions
ClosedPublic

Authored by majcosta on Sep 2 2020, 16:48.

Details

Summary

rpc: Avoid creating non-standard raw transactions (MarcoFalke)

Pull request description:

Multiple OP_RETURN outputs in a transaction are not standard and unlikely to be relayed, so avoid creating them.

Apart from that, the logic was broken in that it duplicated the same hex-data for each data output: Closes #14868.

https://github.com/bitcoin/bitcoin/pull/14890/commits/fa4c8679ed94f215ce895938f7c3c169a2ce101e


Backport of Core PR14890

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Sep 2 2020, 16:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Sep 2 2020, 18:13