[QT] Fix QByteArray.append(const QString) deprecation warning in 5.15.1
ClosedPublic
Actions

Authored by Fabien on Sep 14 2020, 06:50.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCeac687bc4782: [QT] Fix QByteArray.append(const QString) deprecation warning in 5.15.1

Summary

https://doc.qt.io/qt-5/qbytearray-obsolete.html#append-5
This function was implicitely calling toUtf8() to convert the string
to a byte array, so this diff does not change the behavior.

Test Plan

ninja all check-all

Check the deprecation warning is gone at build time.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 14 2020, 06:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 14 2020, 06:50

Fabien requested review of this revision.Sep 14 2020, 06:50

Harbormaster completed remote builds in B12720: Diff 23474.Sep 14 2020, 07:04

Fabien retitled this revision from [QT] Fix QByteArray.append(const QString) deprectation warning in 5.15.1 to [QT] Fix QByteArray.append(const QString) deprecation warning in 5.15.1.Sep 14 2020, 07:51

jasonbcox accepted this revision.Sep 14 2020, 16:21

This revision is now accepted and ready to land.Sep 14 2020, 16:21

Closed by commit rABCeac687bc4782: [QT] Fix QByteArray.append(const QString) deprecation warning in 5.15.1 (authored by Fabien). · Explain WhySep 14 2020, 19:27

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCeac687bc4782: [QT] Fix QByteArray.append(const QString) deprecation warning in 5.15.1.