Page MenuHomePhabricator

[CMAKE] Generate the man pages at install time
ClosedPublic

Authored by Fabien on Sep 15 2020, 07:02.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCaba211fc28f5: [CMAKE] Generate the man pages at install time
Summary

The man pages are currently part of our source tree and maintained as
such despite being generated. This diff removes the man pages from the
source tree and generate them as part of the intallation step. The man
pages are still part of the release delivery.

Test Plan
ninja install-manpages

Check the man pages are installed.

touch ../src/bitcoind.cpp
ninja install-manpages

Check the man pages are regenerated.

touch ../src/bitcoin-cli.cpp
ninja install-manpages

Check only the bitcoin-cli man page is regenerated.

ninja install-manpages-html

Check the html variants of the manpages are installed.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien requested review of this revision.Sep 15 2020, 07:02

Missing quotes in the script

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
doc/man/gen-manpages.sh
46 ↗(On Diff #23491)

We should be using BIN to get the version, but we need to make the --version consistent across all of the binaries first.

This revision is now accepted and ready to land.Sep 15 2020, 16:55