Page MenuHomePhabricator
Differential D7521

[backport#17258] Fix issue with conflicted mempool tx in listsinceblock
Needs RevisionPublic
Actions

Authored by majcosta on Sep 22 2020, 15:43.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

Fix issue with conflicted mempool tx in listsinceblock (Adam Jonas)

Pull request description:

Closes #8752 by bringing back abandoned #10470.

This now checks that returned transactions are not conflicting with any transactions that are filtered out by the given blockhash and add a functional test to prevent this in the future.

For more context, #8757 was closed in favor of #10470.

Backport of Core PR17258

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 22 2020, 15:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 15:43
majcosta requested review of this revision.Sep 22 2020, 15:43
teamcity edited the summary of this revision. (Show Details)Sep 22 2020, 15:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12854: Diff 23681.Sep 22 2020, 15:56
deadalnix requested changes to this revision.Sep 22 2020, 16:03
deadalnix added a subscriber: deadalnix.

There is a test missing.

This revision now requires changes to proceed.Sep 22 2020, 16:03

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines

Diff 23681

View Options

src/wallet/rpcwallet.cpp

Loading...