Page MenuHomePhabricator
Differential D7524

[backport#12173] [Qt] Use flexible font size for QRCode image address
ClosedPublic
Actions

Authored by majcosta on Sep 22 2020, 16:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC357a4cd67bde: [backport#12173] [Qt] Use flexible font size for QRCode image address
Summary

Use flexible font size for QRCode image address (Jonas Schnelli)

Pull request description:

Bech32 addresses are currently cut off in the QRCode image in the GUI receive tab.
This adds a simple font size calculation logic that "must" (down to 4pt) fix into the given image width.

Examples OSX HiDPI:
<img width="332" alt="bildschirmfoto 2018-01-12 um 11 25 40" src="https://user-images.githubusercontent.com/178464/34896144-c0c65d76-f78c-11e7-93e1-94dc8e203269.png">
<img width="322" alt="bildschirmfoto 2018-01-12 um 11 25 46" src="https://user-images.githubusercontent.com/178464/34896145-c0edfe1c-f78c-11e7-8c09-c15155e2160e.png">

Examples Ubuntu non HIDPI:
<img width="314" alt="bildschirmfoto 2018-01-12 um 11 27 51" src="https://user-images.githubusercontent.com/178464/34896151-c88347f4-f78c-11e7-8a03-df8049dcfed6.png">
<img width="322" alt="bildschirmfoto 2018-01-12 um 11 27 42" src="https://user-images.githubusercontent.com/178464/34896152-c8bb881c-f78c-11e7-89d2-6f04ec608a19.png">

Backport of Core PR12173

Test Plan
ninja
bitcoin-qt -regtest, check the receive tab for correctness

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 22 2020, 16:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 16:31
majcosta requested review of this revision.Sep 22 2020, 16:31
teamcity edited the summary of this revision. (Show Details)Sep 22 2020, 16:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Sep 22 2020, 16:37
This revision is now accepted and ready to land.Sep 22 2020, 16:37
Harbormaster completed remote builds in B12859: Diff 23686.Sep 22 2020, 16:43
Closed by commit rABC357a4cd67bde: [backport#12173] [Qt] Use flexible font size for QRCode image address (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhySep 23 2020, 00:08
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC357a4cd67bde: [backport#12173] [Qt] Use flexible font size for QRCode image address.
majcosta mentioned this in D7533: [fix] only use horizontalAdvance for Qt versions which support it.Sep 23 2020, 01:42
majcosta mentioned this in rABC131a31b642fa: [fix] only use horizontalAdvance for Qt versions which support it.Sep 23 2020, 12:50

Revision Contents
Changeset List

PathSize
src/
qt/
3 lines
13 lines
10 lines

Diff 23711

View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/receiverequestdialog.cpp

Loading...