Differential D7525

Prevent UB in DeleteLock() function
ClosedPublic
Actions

Authored by deadalnix on Sep 22 2020, 18:00.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC8b4530e45434: Prevent UB in DeleteLock() function

Summary

refactor: Add LockStackItem type alias
refactor: Add LockPair type alias
refactor: Refactor duplicated code into LockHeld()
Replace thread_local g_lockstack with a mutex-protected map

This change prevents UB in case of early g_lockstack destroying.

Co-authored-by: Wladimir J. van der Laan <laanwj@protonmail.com>

doc: Add and fix comments about never destroyed objects

This is a backport of Core PR18881

Test Plan

ninja all check-all

Also in debug mode.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 22 2020, 18:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 18:00

deadalnix requested review of this revision.Sep 22 2020, 18:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12860: Diff 23689.Sep 22 2020, 18:13

majcosta added a subscriber: majcosta.Sep 22 2020, 19:01

majcosta accepted this revision.Sep 22 2020, 19:12

This revision is now accepted and ready to land.Sep 22 2020, 19:12

Closed by commit rABC8b4530e45434: Prevent UB in DeleteLock() function (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by deadalnix). · Explain WhySep 22 2020, 19:15

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC8b4530e45434: Prevent UB in DeleteLock() function.

Revision Contents
Changeset List

Path

Size

src/

logging.cpp

4 lines

sync.cpp

136 lines

Diff 23692

View Options

src/logging.cpp