Page MenuHomePhabricator

[Backport]gui: hide HD & encryption icons when no wallet loaded
ClosedPublic

Authored by PiRK on Sep 23 2020, 15:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC65c02eebfa7a: [Backport]gui: hide HD & encryption icons when no wallet loaded
Summary

The HD and encrypt status bar icons were not hidden after closing all wallets in bitcoin-qt.

This is a Backport of Bitcoin Core PR17935 and PR18007
The second PR is a fix for a bug introduced by the first.

Test Plan

Reproduce the issue before applying the commits: close all wallets in bitcoin-qt and check that status icons remain visible.
Build, install, create 2 encrypted wallets, check that the icons now disappear when all wallets are closed, but remains visible after closing a wallet if a second wallet is still open.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a reviewer: Restricted Owners Package.Sep 23 2020, 15:20
PiRK requested review of this revision.Sep 23 2020, 15:20

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Snippet of first build failure:

[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Counting objects:  44% (4/9)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Counting objects:  55% (5/9)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Counting objects:  66% (6/9)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Counting objects:  77% (7/9)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Counting objects:  88% (8/9)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Counting objects: 100% (9/9)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Counting objects: 100% (9/9), done.        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Compressing objects:  20% (1/5)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Compressing objects:  40% (2/5)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Compressing objects:  60% (3/5)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Compressing objects:  80% (4/5)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Compressing objects: 100% (5/5)        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Compressing objects: 100% (5/5), done.        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] remote: Total 5 (delta 4), reused 0 (delta 0), pack-reused 0        
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736]  * [new tag]             phabricator/diff/23736 -> phabricator/diff/23736
[15:21:08]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23736:refs/tags/phabricator/diff/23736]  * [new tag]             phabricator/base/23736 -> phabricator/base/23736
[15:21:08] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 5339ac00b998eaabe77a0a847bcf6797bdfb14bf --
[15:21:09] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[15:21:09] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/23736
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 5339ac00b998eaabe77a0a847bcf6797bdfb14bf --
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/23736
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/23736
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[15:21:09] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[15:21:09] : Build preparation done
[15:21:09]E: Step 1/1: Command Line (38s)
[15:21:09] :	 [Step 1/1] Ant JUnit report watcher
[15:21:09] :		 [Ant JUnit report watcher] Watching paths:
[15:21:09] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[15:21:09] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[15:21:09] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script3863400013958821953
[15:21:09] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[15:21:09] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[15:21:09] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[15:21:09] :	 [Step 1/1] Building base image for: 5339ac00b...
[15:21:09] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[15:21:11] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[15:21:11] :	 [Step 1/1] Tag name: abc-base-image-5339ac00b
[15:21:44]W:	 [Step 1/1] Traceback (most recent call last):
[15:21:44]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 556, in <module>
[15:21:44]W:	 [Step 1/1]     main()
[15:21:44]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 545, in main
[15:21:44]W:	 [Step 1/1]     script_dir, config_path, args.build)
[15:21:44]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 59, in __init__
[15:21:44]W:	 [Step 1/1]     self.load(build_name)
[15:21:44]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 82, in load
[15:21:44]W:	 [Step 1/1]     self.name, list(config.keys())
[15:21:44]W:	 [Step 1/1] AssertionError: lint-circular-dependencies is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[15:21:44]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[15:21:44]W:	 [Step 1/1] Try 'mv --help' for more information.
[15:21:48]W:	 [Step 1/1] Process exited with code 1
[15:21:48]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)

Please ignore the failure, I'll investigate

This revision is now accepted and ready to land.Sep 23 2020, 15:29
This revision was landed with ongoing or failed builds.Sep 23 2020, 15:40
This revision was automatically updated to reflect the committed changes.