Remove misplaced Q_UNUSED and others enhancements
ClosedPublic
Actions

Authored by PiRK on Sep 24 2020, 14:46.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC1faef2c7a763: Remove misplaced Q_UNUSED and others enhancements

Summary

Also this removes unused function parameters and improves comments.

Backport of Bitcoin Core PR15007

Test Plan

ninja
bitcoin-qt -regtest

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 24 2020, 14:46

Owners added a reviewer: Restricted Owners Package.Sep 24 2020, 14:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 24 2020, 14:46

PiRK requested review of this revision.Sep 24 2020, 14:46

PiRK edited the summary of this revision. (Show Details)Sep 24 2020, 14:47

deadalnix accepted this revision.Sep 24 2020, 14:48

This revision is now accepted and ready to land.Sep 24 2020, 14:48

Harbormaster completed remote builds in B12899: Diff 23761.Sep 24 2020, 14:55

Closed by commit rABC1faef2c7a763: Remove misplaced Q_UNUSED and others enhancements (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 24 2020, 15:28

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1faef2c7a763: Remove misplaced Q_UNUSED and others enhancements.

Revision Contents
Changeset List

Path

Size

src/

qt/

notificator.h

9 lines

notificator.cpp

27 lines

Diff 23765

View Options

src/qt/notificator.h