Page MenuHomePhabricator
Differential D7562

refactor: Remove addrdb.h dependency from node.h
ClosedPublic
Actions

Authored by PiRK on Sep 25 2020, 09:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC9b0a206751a1: refactor: Remove addrdb.h dependency from node.h
Summary

node.h includes addrdb.h just for the sake of banmap_t type.
This PR makes dependencies simpler and explicit.

This is a backport of Bitcoin Core PR17297

Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 25 2020, 09:05
Owners added a reviewer: Restricted Owners Package.Sep 25 2020, 09:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2020, 09:05
PiRK requested review of this revision.Sep 25 2020, 09:05
teamcity edited the summary of this revision. (Show Details)Sep 25 2020, 09:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12911: Diff 23782.Sep 25 2020, 09:19
Fabien accepted this revision.Sep 25 2020, 10:04
This revision is now accepted and ready to land.Sep 25 2020, 10:04
Closed by commit rABC9b0a206751a1: refactor: Remove addrdb.h dependency from node.h (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 25 2020, 10:28
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC9b0a206751a1: refactor: Remove addrdb.h dependency from node.h.

Revision Contents
Changeset List

PathSize
src/
3 lines
1 line
interfaces/
9 lines
15 lines
qt/
4 lines
rpc/
1 line

Diff 23786

View Options

src/addrdb.h

Loading...
View Options

src/banman.h

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/net_types.h

Loading...
View Options

src/qt/bantablemodel.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...