Page MenuHomePhabricator

refactor: Remove unused defines in bitcoinunits.h
ClosedPublic

Authored by PiRK on Sat, Sep 26, 06:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC523cfa04d58b: refactor: Remove unused defines in bitcoinunits.h
Summary

This code was added in 7007402 and unused in the very next commit 2e4fee2

Backport of Core PR17869

Test Plan
for IDENTIFIER in REAL_THIN_SP_HTML HAIR_SP_CP HAIR_SP_UTF8 HAIR_SP_HTML SIXPEREM_SP_CP SIXPEREM_SP_UTF8 SIXPEREM_SP_HTML FIGURE_SP_CP FIGURE_SP_UTF8 FIGURE_SP_HTML;
do
     grep -r $IDENTIFIER src/;
done

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a reviewer: Restricted Owners Package.Sat, Sep 26, 06:09
PiRK requested review of this revision.Sat, Sep 26, 06:09
deadalnix requested changes to this revision.Sun, Sep 27, 14:25
deadalnix added a subscriber: deadalnix.

The test plan doesn't cover the change made.

This revision now requires changes to proceed.Sun, Sep 27, 14:25
PiRK edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Mon, Sep 28, 14:33