Page MenuHomePhabricator
Differential D7577

refactor: Remove unused defines in bitcoinunits.h
ClosedPublic
Actions

Authored by PiRK on Sep 26 2020, 06:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC523cfa04d58b: refactor: Remove unused defines in bitcoinunits.h
Summary

This code was added in 7007402 and unused in the very next commit 2e4fee2

Backport of Core PR17869

Test Plan
for IDENTIFIER in REAL_THIN_SP_HTML HAIR_SP_CP HAIR_SP_UTF8 HAIR_SP_HTML SIXPEREM_SP_CP SIXPEREM_SP_UTF8 SIXPEREM_SP_HTML FIGURE_SP_CP FIGURE_SP_UTF8 FIGURE_SP_HTML;
do
     grep -r $IDENTIFIER src/;
done

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 26 2020, 06:09
Owners added a reviewer: Restricted Owners Package.Sep 26 2020, 06:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2020, 06:09
PiRK requested review of this revision.Sep 26 2020, 06:09
Harbormaster completed remote builds in B12937: Diff 23826.Sep 26 2020, 06:20
deadalnix requested changes to this revision.Sep 27 2020, 14:25
deadalnix added a subscriber: deadalnix.

The test plan doesn't cover the change made.

This revision now requires changes to proceed.Sep 27 2020, 14:25
PiRK edited the summary of this revision. (Show Details)Sep 28 2020, 09:24
PiRK updated this revision to Diff 23877.Sep 28 2020, 09:54

update test plan

PiRK edited the test plan for this revision. (Show Details)Sep 28 2020, 09:54
PiRK edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B12967: Diff 23877.Sep 28 2020, 10:05
deadalnix accepted this revision.Sep 28 2020, 14:33
This revision is now accepted and ready to land.Sep 28 2020, 14:33
Closed by commit rABC523cfa04d58b: refactor: Remove unused defines in bitcoinunits.h (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 28 2020, 14:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC523cfa04d58b: refactor: Remove unused defines in bitcoinunits.h.

Revision Contents
Changeset List

PathSize
src/
qt/
19 lines

Diff 23884

View Options

src/qt/bitcoinunits.h

Loading...