Differential D7592

remove dead store in ecdsa_signature_parse_der_lax
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2020, 22:31.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC1f985e5a3bcf: remove dead store in ecdsa_signature_parse_der_lax

Summary

This change was made in bitcoin/bitcoin without upstreaming. So this is
a followup to the comment here:
https://github.com/bitcoin/bitcoin/pull/19228#issuecomment-641795558.

This is a backport of libsecp256k1 PR765

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 27 2020, 22:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 22:31

deadalnix requested review of this revision.Sep 27 2020, 22:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12957: Diff 23851.Sep 27 2020, 22:44

majcosta accepted this revision.Sep 27 2020, 23:01

This revision is now accepted and ready to land.Sep 27 2020, 23:01

Closed by commit rABC1f985e5a3bcf: remove dead store in ecdsa_signature_parse_der_lax (authored by fanquake <fanquake@gmail.com>, committed by deadalnix). · Explain WhySep 27 2020, 23:05

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC1f985e5a3bcf: remove dead store in ecdsa_signature_parse_der_lax.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

contrib/

lax_der_parsing.c

1 line

Diff 23863

View Options

src/secp256k1/contrib/lax_der_parsing.c

remove dead store in ecdsa_signature_parse_der_laxClosedPublicActions