Page MenuHomePhabricator
Differential D7611

Initialize field elements when resulting in infinity
ClosedPublic
Actions

Authored by deadalnix on Sep 28 2020, 15:53.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC13f2aeb050a2: Initialize field elements when resulting in infinity
Summary
  • Added test with additions resulting in infinity
  • Clear field elements when writing infinity

This is a backport of secp256k1 PR699

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 28 2020, 15:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2020, 15:53
deadalnix requested review of this revision.Sep 28 2020, 15:53
teamcity edited the summary of this revision. (Show Details)Sep 28 2020, 15:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12978: Diff 23890.Sep 28 2020, 16:17
jasonbcox accepted this revision.Sep 28 2020, 16:28
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/secp256k1/src/tests.c
2310 ↗(On Diff #23890)

Nit: intialized -> initialized but the typo is in the original PR, so v0v

This revision is now accepted and ready to land.Sep 28 2020, 16:28
Closed by commit rABC13f2aeb050a2: Initialize field elements when resulting in infinity (authored by Elichai Turkel <elichai.turkel@gmail.com>, committed by deadalnix). · Explain WhySep 28 2020, 16:36
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC13f2aeb050a2: Initialize field elements when resulting in infinity.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
6 lines
34 lines

Diff 23900

View Options

src/secp256k1/src/group_impl.h

Loading...
View Options

src/secp256k1/src/tests.c

Loading...