Differential D7636

Make the secp256k1_declassify argument constant
ClosedPublic
Actions

Authored by deadalnix on Sep 29 2020, 10:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5ab6cb06f7c9: Make the secp256k1_declassify argument constant

Summary

This is required to declassify pointers to constant memory. Declassify should
never modify its argument.

This is a partial backport of secp256k1 PR558 : https://github.com/bitcoin-core/secp256k1/pull/558/commits/3e08b02e2a78f2a1fc457efab665db8ab8085373

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 29 2020, 10:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 10:01

deadalnix requested review of this revision.Sep 29 2020, 10:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Sep 29 2020, 10:05

This revision is now accepted and ready to land.Sep 29 2020, 10:05

This revision was landed with ongoing or failed builds.Sep 29 2020, 10:21

Closed by commit rABC5ab6cb06f7c9: Make the secp256k1_declassify argument constant (authored by Jonas Nick <jonasd.nick@gmail.com>, committed by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC5ab6cb06f7c9: Make the secp256k1_declassify argument constant.

Harbormaster completed remote builds in B13012: Diff 23955.Sep 29 2020, 10:37

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

secp256k1.c

2 lines

Diff 23958

View Options

src/secp256k1/src/secp256k1.c

Make the secp256k1_declassify argument constantClosedPublicActions