Differential D7661

[SECP256K1] Fix some travis issues on macOS
ClosedPublic
Actions

Authored by Fabien on Sep 29 2020, 12:49.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCa83300b50841: [SECP256K1] Fix some travis issues on macOS

Summary

The Homebrew addon is not compatible with versioned package installation, so do it manually: https://travis-ci.org/github/Fabcien/secp256k1/jobs/731184075
The valgrind test times out on macOS. As per https://reviews.bitcoinabc.org/D7633?id=23949#inline-43274 the test is run twice, with autotools and cmake, which isn't really necessary. Running it only with autotools will help avoiding the timeout.

Test Plan

Run the Travis build.
Actually failing:
https://travis-ci.org/github/Fabcien/secp256k1/builds/731184003

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 29 2020, 12:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 12:49

Fabien requested review of this revision.Sep 29 2020, 12:49

deadalnix accepted this revision.Sep 29 2020, 12:52

This revision is now accepted and ready to land.Sep 29 2020, 12:52

This revision was landed with ongoing or failed builds.Sep 29 2020, 13:09

Closed by commit rABCa83300b50841: [SECP256K1] Fix some travis issues on macOS (authored by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa83300b50841: [SECP256K1] Fix some travis issues on macOS.

Harbormaster completed remote builds in B13043: Diff 24003.Sep 29 2020, 13:26

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

2 lines

travis/

8 lines

Diff 24018

src/secp256k1/.travis.yml

Loading...

src/secp256k1/travis/build_cmake.sh

Loading...