Page MenuHomePhabricator
Differential D7684

[backport#17444] wallet: Avoid showing GUI popups on RPC errors (take 2)
ClosedPublic
Actions

Authored by majcosta on Sep 30 2020, 19:45.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCa93566bb87fb: [backport#17444] wallet: Avoid showing GUI popups on RPC errors (take 2)
Summary

wallet: Avoid showing GUI popups on RPC errors (take 2) (MarcoFalke)

Pull request description:

Commit 8b0d82bb428de9e7f1da7c61574e7a8376a62d43 claims "This commit does not change behavior." However, it re-introduced the bug I tried to fix in #17070

Backport of Core PR17444

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 30 2020, 19:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2020, 19:45
majcosta requested review of this revision.Sep 30 2020, 19:45
teamcity edited the summary of this revision. (Show Details)Sep 30 2020, 19:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13077: Diff 24069.Sep 30 2020, 19:58
jasonbcox accepted this revision.Sep 30 2020, 21:16
This revision is now accepted and ready to land.Sep 30 2020, 21:16
Closed by commit rABCa93566bb87fb: [backport#17444] wallet: Avoid showing GUI popups on RPC errors (take 2) (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhySep 30 2020, 21:45
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCa93566bb87fb: [backport#17444] wallet: Avoid showing GUI popups on RPC errors (take 2).

Revision Contents
Changeset List

PathSize
src/
wallet/
1 line

Diff 24074

View Options

src/wallet/wallet.cpp

Loading...