Differential D7709

[backport#17405] wallet: Remove unused boost::this_thread::interruption_point
ClosedPublic
Actions

Authored by majcosta on Oct 1 2020, 14:16.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe51055fa300b: [backport#17405] wallet: Remove unused boost::this_thread::interruption_point

Summary

fad1de66a29bf6bd348a932150dad7d472feb3d0 wallet: Remove unused boost::this_thread::interruption_point (MarcoFalke)

Pull request description:

`BerkeleyEnvironment::Open` is only called from the main thread (init) or an http rpc thread, neither of which can be interrupted, so remove the useless interruption point.

`BerkeleyEnvironment{}` is only used in tests, which run in a single process/thread, so remove the useless interruption point.

Backport of Core PR17405

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 1 2020, 14:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2020, 14:16

majcosta requested review of this revision.Oct 1 2020, 14:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Oct 1 2020, 14:22

This revision is now accepted and ready to land.Oct 1 2020, 14:22

This revision was landed with ongoing or failed builds.Oct 1 2020, 14:31

Closed by commit rABCe51055fa300b: [backport#17405] wallet: Remove unused boost::this_thread::interruption_point (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain Why

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCe51055fa300b: [backport#17405] wallet: Remove unused boost::this_thread::interruption_point.

Harbormaster completed remote builds in B13114: Diff 24130.Oct 1 2020, 14:56

Revision Contents
Changeset List

Path

Size

src/

wallet/

7 lines

Diff 24135

src/wallet/db.cpp

Loading...