tests: Added missing tests for RPC wallet errors
ClosedPublic
Actions

Authored by PiRK on Oct 1 2020, 14:41.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC1884ca2a13c8: tests: Added missing tests for RPC wallet errors

Summary

Backport of Core PR15378

Test Plan

ninja && ./test/functional/test_runner.py wallet_basic

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 1 2020, 14:41

Owners added a reviewer: Restricted Owners Package.Oct 1 2020, 14:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2020, 14:41

PiRK requested review of this revision.Oct 1 2020, 14:41

Fabien edited the summary of this revision. (Show Details)Oct 1 2020, 15:07

Please use PR# syntax in the summary so we use the same style everywhere and can grep for it

This revision is now accepted and ready to land.Oct 1 2020, 15:09

Harbormaster completed remote builds in B13116: Diff 24137.Oct 1 2020, 15:11

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[0m[1;30mwallet_hd.py                            | ○ Skipped | 0 s
[0m[1;30mwallet_import_rescan.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_import_with_label.py             | ○ Skipped | 0 s
[0m[1;30mwallet_importmulti.py                   | ○ Skipped | 0 s
[0m[1;30mwallet_importprunedfunds.py             | ○ Skipped | 0 s
[0m[1;30mwallet_keypool.py                       | ○ Skipped | 0 s
[0m[1;30mwallet_keypool_topup.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_labels.py                        | ○ Skipped | 0 s
[0m[1;30mwallet_listreceivedby.py                | ○ Skipped | 0 s
[0m[1;30mwallet_listsinceblock.py                | ○ Skipped | 0 s
[0m[1;30mwallet_listtransactions.py              | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py                   | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py --usecli          | ○ Skipped | 0 s
[0m[1;30mwallet_reorgsrestore.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_resendwallettransactions.py      | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py                     | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py --mineblock         | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py               | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py --mineblock   | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py                     | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py --usecli            | ○ Skipped | 0 s
[0m[1;30mwallet_zapwallettxes.py                 | ○ Skipped | 0 s
[0m[0;31mp2p_timeouts.py                         | ✖ Failed  | 7 s
[0m[0;31m[1m
ALL                                     | ✖ Failed  | 347 s (accumulated) 
[0m[0mRuntime: 85 s

[22/373] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[23/373] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[113/373] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:541:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[157/373] Running seeder test suite
PASSED: seeder test suite
[160/373] Running avalanche test suite
PASSED: avalanche test suite
[351/373] Running pow test suite
PASSED: pow test suite
[369/373] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[372/373] Running bitcoin test suite
PASSED: bitcoin test suite
FAILED: test/CMakeFiles/check-functional 
cd /work/abc-ci-builds/build-without-wallet/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py "--testsuitename=Bitcoin ABC functional tests" --junitoutput=/work/abc-ci-builds/build-without-wallet/test/junit/functional_tests.xml
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_timeouts.py

This revision was landed with ongoing or failed builds.Oct 1 2020, 15:34

Closed by commit rABC1884ca2a13c8: tests: Added missing tests for RPC wallet errors (authored by Ben Carman <benthecarman@live.com>, committed by PiRK). · Explain Why

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1884ca2a13c8: tests: Added missing tests for RPC wallet errors.