Page MenuHomePhabricator

remove some magic mining constants in functional tests
ClosedPublic

Authored by PiRK on Thu, Oct 1, 15:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC5abfa6f26e60: remove some magic mining constants in functional tests
Summary

Backport of Core PR15238

Test Plan

ninja && ./test/functional/test_runner.py interface_rest mining_basic

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a reviewer: Restricted Owners Package.Thu, Oct 1, 15:07
PiRK requested review of this revision.Thu, Oct 1, 15:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Thu, Oct 1, 15:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/mining_basic.py
21 ↗(On Diff #24141)

trailing comma

211 ↗(On Diff #24141)

That's not what is in the PR

This revision now requires changes to proceed.Thu, Oct 1, 15:12
PiRK removed a reviewer: Fabien. PiRK added 1 blocking reviewer(s): Restricted Owners Package.

squash the second commit

This revision is now accepted and ready to land.Thu, Oct 1, 15:17
test/functional/mining_basic.py
211 ↗(On Diff #24141)

I almost forgot to include the second commit https://github.com/bitcoin/bitcoin/pull/15238/commits/b651ef7e1c39a820089695b29d14a07d910a385a

It's fixed now, I squashed the 2 commits.

Snippet of first build failure:

[348/409] bitcoin: testing streams_tests
[349/409] Running utility command for check-bitcoin-settings_tests
[350/409] bitcoin: testing timedata_tests
[351/409] Running utility command for check-bitcoin-streams_tests
[352/409] Running utility command for check-bitcoin-timedata_tests
[353/409] bitcoin: testing checkdatasig_tests
[354/409] Running utility command for check-bitcoin-checkdatasig_tests
[355/409] bitcoin: testing uint256_tests
[356/409] bitcoin: testing serialize_tests
[357/409] Running utility command for check-bitcoin-uint256_tests
[358/409] bitcoin: testing sigencoding_tests
[359/409] Running utility command for check-bitcoin-serialize_tests
[360/409] Running utility command for check-bitcoin-sigencoding_tests
[361/409] bitcoin: testing checkqueue_tests
[362/409] Running utility command for check-bitcoin-checkqueue_tests
[363/409] bitcoin: testing walletdb_tests
[364/409] bitcoin: testing undo_tests
[365/409] bitcoin: testing radix_tests
[366/409] Running utility command for check-bitcoin-walletdb_tests
[367/409] Running utility command for check-bitcoin-undo_tests
[368/409] Running utility command for check-bitcoin-radix_tests
[369/409] bitcoin: testing util_threadnames_tests
[370/409] Running utility command for check-bitcoin-util_threadnames_tests
[371/409] bitcoin: testing script_standard_tests
[372/409] bitcoin: testing blockcheck_tests
[373/409] bitcoin: testing crypto_tests
[374/409] Running utility command for check-bitcoin-script_standard_tests
[375/409] Running utility command for check-bitcoin-blockcheck_tests
[376/409] bitcoin: testing blockstatus_tests
[377/409] Running utility command for check-bitcoin-crypto_tests
[378/409] Running utility command for check-bitcoin-blockstatus_tests
[379/409] bitcoin: testing ismine_tests
[380/409] bitcoin: testing cashaddr_tests
[381/409] Running utility command for check-bitcoin-ismine_tests
[382/409] Running utility command for check-bitcoin-cashaddr_tests
[383/409] bitcoin: testing versionbits_tests
[384/409] bitcoin: testing getarg_tests
[385/409] bitcoin: testing script_tests
[386/409] Running utility command for check-bitcoin-versionbits_tests
[387/409] Running utility command for check-bitcoin-getarg_tests
[388/409] Running utility command for check-bitcoin-script_tests
[389/409] bitcoin: testing bswap_tests
[390/409] Running utility command for check-bitcoin-bswap_tests
[391/409] bitcoin: testing validation_tests
[392/409] Running utility command for check-bitcoin-validation_tests
[393/409] bitcoin: testing skiplist_tests
[394/409] Running utility command for check-bitcoin-skiplist_tests
[395/409] bitcoin: testing validation_block_tests
[396/409] Running utility command for check-bitcoin-validation_block_tests
[397/409] bitcoin: testing util_tests
[398/409] Running utility command for check-bitcoin-util_tests
[399/409] bitcoin: testing cuckoocache_tests
[400/409] Running utility command for check-bitcoin-cuckoocache_tests
[401/409] bitcoin: testing op_reversebytes_tests
[402/409] Running utility command for check-bitcoin-op_reversebytes_tests
[403/409] bitcoin: testing coins_tests
[404/409] Running utility command for check-bitcoin-coins_tests
[405/409] bitcoin: testing transaction_tests
[406/409] Running utility command for check-bitcoin-transaction_tests
Build build-clang timed out after 1200.0s

Snippet of first build failure:

[348/409] Running utility command for check-bitcoin-torcontrol_tests
[349/409] bitcoin: testing settings_tests
[350/409] bitcoin: testing timedata_tests
[351/409] bitcoin: testing streams_tests
[352/409] Running utility command for check-bitcoin-settings_tests
[353/409] Running utility command for check-bitcoin-streams_tests
[354/409] Running utility command for check-bitcoin-timedata_tests
[355/409] bitcoin: testing checkdatasig_tests
[356/409] Running utility command for check-bitcoin-checkdatasig_tests
[357/409] bitcoin: testing uint256_tests
[358/409] Running utility command for check-bitcoin-uint256_tests
[359/409] bitcoin: testing undo_tests
[360/409] bitcoin: testing walletdb_tests
[361/409] Running utility command for check-bitcoin-undo_tests
[362/409] Running utility command for check-bitcoin-walletdb_tests
[363/409] bitcoin: testing util_threadnames_tests
[364/409] bitcoin: testing serialize_tests
[365/409] Running utility command for check-bitcoin-util_threadnames_tests
[366/409] Running utility command for check-bitcoin-serialize_tests
[367/409] bitcoin: testing sigencoding_tests
[368/409] Running utility command for check-bitcoin-sigencoding_tests
[369/409] bitcoin: testing radix_tests
[370/409] Running utility command for check-bitcoin-radix_tests
[371/409] bitcoin: testing script_standard_tests
[372/409] Running utility command for check-bitcoin-script_standard_tests
[373/409] bitcoin: testing blockcheck_tests
[374/409] bitcoin: testing crypto_tests
[375/409] Running utility command for check-bitcoin-blockcheck_tests
[376/409] bitcoin: testing blockstatus_tests
[377/409] Running utility command for check-bitcoin-crypto_tests
[378/409] bitcoin: testing ismine_tests
[379/409] Running utility command for check-bitcoin-blockstatus_tests
[380/409] Running utility command for check-bitcoin-ismine_tests
[381/409] bitcoin: testing versionbits_tests
[382/409] bitcoin: testing cashaddr_tests
[383/409] bitcoin: testing validation_block_tests
[384/409] bitcoin: testing getarg_tests
[385/409] Running utility command for check-bitcoin-versionbits_tests
[386/409] Running utility command for check-bitcoin-cashaddr_tests
[387/409] Running utility command for check-bitcoin-validation_block_tests
[388/409] bitcoin: testing validation_tests
[389/409] Running utility command for check-bitcoin-getarg_tests
[390/409] Running utility command for check-bitcoin-validation_tests
[391/409] bitcoin: testing bswap_tests
[392/409] bitcoin: testing script_tests
[393/409] Running utility command for check-bitcoin-bswap_tests
[394/409] Running utility command for check-bitcoin-script_tests
[395/409] bitcoin: testing skiplist_tests
[396/409] Running utility command for check-bitcoin-skiplist_tests
[397/409] bitcoin: testing util_tests
[398/409] Running utility command for check-bitcoin-util_tests
[399/409] bitcoin: testing cuckoocache_tests
[400/409] bitcoin: testing op_reversebytes_tests
[401/409] Running utility command for check-bitcoin-cuckoocache_tests
[402/409] Running utility command for check-bitcoin-op_reversebytes_tests
[403/409] bitcoin: testing coins_tests
[404/409] Running utility command for check-bitcoin-coins_tests
[405/409] bitcoin: testing transaction_tests
[406/409] Running utility command for check-bitcoin-transaction_tests
Build build-clang timed out after 1200.0s

Snippet of first build failure:

[343/402] Running utility command for check-bitcoin-streams_tests
[344/402] bitcoin: testing uint256_tests
[345/402] Running utility command for check-bitcoin-uint256_tests
[346/402] bitcoin: testing undo_tests
[347/402] Running utility command for check-bitcoin-undo_tests
[348/402] bitcoin: testing walletdb_tests
[349/402] bitcoin: testing serialize_tests
[350/402] bitcoin: testing util_threadnames_tests
[351/402] Running utility command for check-bitcoin-walletdb_tests
[352/402] Running utility command for check-bitcoin-util_threadnames_tests
[353/402] Running utility command for check-bitcoin-serialize_tests
[354/402] bitcoin: testing radix_tests
[355/402] bitcoin: testing validationinterface_tests
[356/402] bitcoin: testing script_standard_tests
[357/402] Running utility command for check-bitcoin-radix_tests
[358/402] Running utility command for check-bitcoin-validationinterface_tests
[359/402] Running utility command for check-bitcoin-script_standard_tests
[360/402] bitcoin: testing blockcheck_tests
[361/402] Running utility command for check-bitcoin-blockcheck_tests
[362/402] bitcoin: testing crypto_tests
[363/402] Running utility command for check-bitcoin-crypto_tests
[364/402] bitcoin: testing blockstatus_tests
[365/402] bitcoin: testing ismine_tests
[366/402] Running utility command for check-bitcoin-ismine_tests
[367/402] Running utility command for check-bitcoin-blockstatus_tests
[368/402] bitcoin: testing validation_tests
[369/402] bitcoin: testing cashaddr_tests
[370/402] bitcoin: testing getarg_tests
[371/402] Running utility command for check-bitcoin-validation_tests
[372/402] Running utility command for check-bitcoin-cashaddr_tests
[373/402] Running utility command for check-bitcoin-getarg_tests
[374/402] bitcoin: testing script_tests
[375/402] Running utility command for check-pow-aserti32d_tests
[376/402] Running utility command for check-bitcoin-script_tests
[377/402] Running pow test suite
PASSED: pow test suite
[378/402] bitcoin: testing versionbits_tests
[379/402] Running utility command for check-bitcoin-versionbits_tests
[380/402] bitcoin: testing bswap_tests
[381/402] Running utility command for check-bitcoin-bswap_tests
[382/402] bitcoin: testing skiplist_tests
[383/402] Running utility command for check-bitcoin-skiplist_tests
[384/402] bitcoin: testing transaction_tests
[385/402] Running utility command for check-bitcoin-transaction_tests
[386/402] bitcoin: testing util_tests
[387/402] bitcoin: testing validation_block_tests
[388/402] Running utility command for check-bitcoin-util_tests
[389/402] Running utility command for check-bitcoin-validation_block_tests
[390/402] bitcoin: testing op_reversebytes_tests
[391/402] Running utility command for check-bitcoin-op_reversebytes_tests
[392/402] bitcoin: testing cuckoocache_tests
[393/402] Running utility command for check-bitcoin-cuckoocache_tests
[394/402] bitcoin: testing coins_tests
[395/402] Running utility command for check-bitcoin-coins_tests
[396/402] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[397/402] Linking CXX executable src/qt/test/test_bitcoin-qt
[398/402] bitcoin-qt: testing test_bitcoin-qt
[399/402] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
Build build-clang-tidy timed out after 1800.0s
This revision was landed with ongoing or failed builds.Fri, Oct 2, 07:03
This revision was automatically updated to reflect the committed changes.