Page MenuHomePhabricator

Avoid dh_missing warnings when building the debian package
ClosedPublic

Authored by Fabien on Oct 2 2020, 08:28.

Details

Summary

The dh_missing helper checks that all the files from the tmp directory
have an installation rule. Otherwise:

  • With compat level < 12: it silently ignores the files
  • With compat level 12: it warns about the presence of these files
  • With compat level > 12: it errors out in the presence of these files

This diff improves our build wrt dh_missing by avoiding putting files
to the tmp directory which are not installed (namely the
bitcoinconsensus library and the seeder), and enforce dh_missing to
raise a warning if some files remain. It doesn't change the current
behavior since we are using compat level 12 but will prevent future
builds from failing if this level is bumped.

Test Plan

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Oct 2 2020, 08:28
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
contrib/debian/rules
14 ↗(On Diff #24194)

Why not install it too?

This revision is now accepted and ready to land.Oct 2 2020, 14:11
contrib/debian/rules
14 ↗(On Diff #24194)

I think the man pages are mandatory and we don't have any for the seeder, but I didn't try (will do).