Page MenuHomePhabricator
Differential D7734

cli: replace testnet with chain and return network name as per BIP70.
ClosedPublic
Actions

Authored by PiRK on Oct 2 2020, 08:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC406bb3cac22d: cli: replace testnet with chain and return network name as per BIP70.
Summary

Backport of Core PR15566

Test Plan

ninja && ninja check-functional

Install and test:
bitcoin-cli -getinfo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 2 2020, 08:54
Owners added a reviewer: Restricted Owners Package.Oct 2 2020, 08:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2020, 08:55
PiRK requested review of this revision.Oct 2 2020, 08:55
teamcity edited the summary of this revision. (Show Details)Oct 2 2020, 08:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

PiRK added a comment.Oct 2 2020, 08:56

Note that this breaks compatibility. If we want to maintain it (and diverge from Core on this point), it would be easy to keep also the testnet field.

Harbormaster completed remote builds in B13150: Diff 24195.Oct 2 2020, 09:05
Fabien accepted this revision.Oct 2 2020, 09:13
This revision is now accepted and ready to land.Oct 2 2020, 09:13
Closed by commit rABC406bb3cac22d: cli: replace testnet with chain and return network name as per BIP70. (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyOct 2 2020, 11:55
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC406bb3cac22d: cli: replace testnet with chain and return network name as per BIP70..

Revision Contents
Changeset List

PathSize
doc/
5 lines
src/
6 lines
test/
functional/
3 lines

Diff 24202

View Options

doc/release-notes.md

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

test/functional/interface_bitcoin_cli.py

Loading...