Remove unused AES-128 code
AbandonedPublic
Actions

Authored by PiRK on Oct 2 2020, 16:00.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

PR description:

As far as I can tell this AES-128 code has never been in use in the project (outside of testing/benchmarking).

The AES-256 code is used in CCrypter::Encrypt/CCrypter::Decrypt (src/wallet/crypter.cpp).

Trivia: 0.15% of the project's C++ LOC count (excluding dependencies) is trimmed off

Backport of Core PR15663

Test Plan

ninja && ninja check
src/bench/bitcoin-bench

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr15663

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13163
Build 26376: Build Diff	lint-circular-dependencies · build-clang · build-clang-tidy · build-without-wallet · build-diff
Build 26375: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 2 2020, 16:00

Owners added a reviewer: Restricted Owners Package.Oct 2 2020, 16:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2020, 16:00

PiRK requested review of this revision.Oct 2 2020, 16:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13163: Diff 24213.Oct 2 2020, 16:11

This was kept on purpose. It's well tested and self sufficient, and may turn out useful, for instance we plan to encrypt the network traffic using QUIC and AES128 would make a good candidate for this.

This revision now requires changes to proceed.Oct 2 2020, 19:01

Diff abandoned.