Differential D7754

qt: Fix QFileDialog for static builds
ClosedPublic
Actions

Authored by Fabien on Oct 5 2020, 08:12.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC0bd424bcb8c9: qt: Fix QFileDialog for static builds

Summary

This change partially reverts 248e22bbc0d7bc40ae3584d53a18507c46b0e553.

Backport of core PR19536.

Test Plan

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake
ninja

With no existing data directory:

./src/qt/bitcoin-qt

In the Welcome dialog, select "Use a custom data directory" and browse
for a path. Before this patch browsing was broken.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 5 2020, 08:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2020, 08:12

Fabien requested review of this revision.Oct 5 2020, 08:12

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13177: Diff 24241.Oct 5 2020, 08:24

majcosta accepted this revision.Oct 5 2020, 14:22

This revision is now accepted and ready to land.Oct 5 2020, 14:22

Closed by commit rABC0bd424bcb8c9: qt: Fix QFileDialog for static builds (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyOct 5 2020, 16:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0bd424bcb8c9: qt: Fix QFileDialog for static builds.

Revision Contents
Changeset List

Path

Size

depends/

packages/

qt.mk

1 line

Diff 24268

View Options

qt: Fix QFileDialog for static buildsClosedPublicActions