Differential D7771

[CMAKE] Fix version in the man2html template
ClosedPublic
Actions

Authored by Fabien on Oct 5 2020, 18:53.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC6f59a8facadb: [CMAKE] Fix version in the man2html template

Summary

The template uses PROJECT_VERSION, which might be empty for subprojects.
What we want here is the top level project version, so the right
variable is CMAKE_PROJECT_VERSION.

Test Plan

cmake -GNinja ..

Check the script has the correct version number.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 5 2020, 18:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2020, 18:53

Fabien requested review of this revision.Oct 5 2020, 18:53

jasonbcox accepted this revision.Oct 5 2020, 18:54

This revision is now accepted and ready to land.Oct 5 2020, 18:54

This revision was landed with ongoing or failed builds.Oct 5 2020, 18:55

Closed by commit rABC6f59a8facadb: [CMAKE] Fix version in the man2html template (authored by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6f59a8facadb: [CMAKE] Fix version in the man2html template.

Harbormaster completed remote builds in B13196: Diff 24274.Oct 5 2020, 19:05

jasonbcox mentioned this in D7772: Fix 0.22.3 manpages not appearing in the doc index.Oct 5 2020, 19:08

jasonbcox mentioned this in rABCWEBce1e353fd0bf: Fix 0.22.3 manpages not appearing in the doc index.Oct 5 2020, 21:05

jasonbcox mentioned this in D7785: Apply cherry-pick before cmake.Oct 6 2020, 15:59

jasonbcox mentioned this in rABCWEBb94b4268192a: Apply cherry-pick before cmake.Oct 6 2020, 16:05

Revision Contents
Changeset List

Path

Size

cmake/

templates/

man2html.sh.in

Diff 24275

View Options

cmake/templates/man2html.sh.in

[CMAKE] Fix version in the man2html templateClosedPublicActions