Page MenuHomePhabricator
Differential D779

Remove redundant conditional expression
ClosedPublic
Actions

Authored by deadalnix on Dec 10 2017, 22:48.

Details

Reviewers
schancel
MattBitprim
Group Reviewers
Restricted Project
Commits
rSTAGING314e925e2fbf: Remove redundant conditional expression
rABC314e925e2fbf: Remove redundant conditional expression
Summary

Back of PR#468 by Dag Robole

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 10 2017, 22:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2017, 22:48
Harbormaster completed remote builds in B1308: Diff 2027.Dec 10 2017, 22:48
schancel added a comment.Dec 11 2017, 04:21

It's hard for me to believe this was unintentionally left there. Are we sure this isn't to prevent some crazy side channel attack? Though the author should have left a comment.

deadalnix updated this revision to Diff 2073.Dec 12 2017, 00:28

Ping ?

schancel accepted this revision.Dec 12 2017, 01:32
This revision is now accepted and ready to land.Dec 12 2017, 01:32
Closed by commit rABC314e925e2fbf: Remove redundant conditional expression (authored by deadalnix). · Explain WhyDec 12 2017, 03:18
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
2 lines

Diff 2079

View Options

src/secp256k1/src/ecdsa_impl.h

Loading...