Paths

Table of Contentst

gui: Set progressDialog to nullptr
ClosedPublic
Actions

Authored by PiRK on Oct 7 2020, 13:07.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCa3081fc09220: gui: Set progressDialog to nullptr

Summary

The progress dialog pointer must be set to nullptr after deletion,
else it can cause a crash is showProgress is called again with n>0.

Backport of Core PR16135

Test Plan

ninja && ninja check

Run ./bitcoin-qt Menu help -> debug -> console
In the console, run:

rescanblockchain
dumpwallet /tmp/wallet
importwallet /tmp/wallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 7 2020, 13:07

Owners added a reviewer: Restricted Owners Package.Oct 7 2020, 13:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2020, 13:07

PiRK requested review of this revision.Oct 7 2020, 13:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13236: Diff 24334.Oct 7 2020, 13:21

deadalnix accepted this revision.Oct 7 2020, 18:36

This revision is now accepted and ready to land.Oct 7 2020, 18:36

Trying to run this code in the wallet neds to be part of the test plan.

This revision now requires changes to proceed.Oct 7 2020, 18:37

Updated test plan with console RPC calls. rescanblockchain calls WalletView::showProgress. importwallet calls BitcoinGUI::showProgress.

deadalnix accepted this revision.Oct 8 2020, 12:00

This revision is now accepted and ready to land.Oct 8 2020, 12:00

Closed by commit rABCa3081fc09220: gui: Set progressDialog to nullptr (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyOct 8 2020, 13:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa3081fc09220: gui: Set progressDialog to nullptr.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.cpp

1 line

walletview.cpp

1 line

Diff 24389

View Options

src/qt/bitcoingui.cpp