Page MenuHomePhabricator
Differential D7800

[backport#17924] Bug: IsUsedDestination shouldn't use key id as script id for ScriptHash
ClosedPublic
Actions

Authored by majcosta on Oct 7 2020, 15:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCaffe4ede9e28: [backport#17924] Bug: IsUsedDestination shouldn't use key id as script id for…
Summary

6dd59d2e491bc11ab26498668543e65440a3a931 Don't allow implementers to think ScriptHash(Witness*()) results in nesting computation (Gregory Sanders)
4b8f1e989f3b969dc628b0801d5c31ebd373719c IsUsedDestination shouldn't use key id as script id for ScriptHash (Gregory Sanders)

Pull request description:

Regression introduced in https://github.com/bitcoin/bitcoin/pull/17621 which causes p2sh-segwit addresses to be erroneously missed.

Tests are only failing in 0.19 branch, likely because that release still uses p2sh-segwit addresses rather than bech32 by default.

I'll devise a test case to catch this going forward.

Backport of Core PR17924

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 7 2020, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2020, 15:25
majcosta requested review of this revision.Oct 7 2020, 15:25
teamcity edited the summary of this revision. (Show Details)Oct 7 2020, 15:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Oct 7 2020, 15:37
This revision is now accepted and ready to land.Oct 7 2020, 15:37
Harbormaster completed remote builds in B13238: Diff 24339.Oct 7 2020, 15:37
Closed by commit rABCaffe4ede9e28: [backport#17924] Bug: IsUsedDestination shouldn't use key id as script id for… (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyOct 7 2020, 16:07
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCaffe4ede9e28: [backport#17924] Bug: IsUsedDestination shouldn't use key id as script id for….

Revision Contents
Changeset List

PathSize
src/
script/
4 lines

Diff 24344

View Options

src/script/standard.h

Loading...