rpc: Clarify that block count means height excl genesis
ClosedPublic
Actions

Authored by PiRK on Oct 8 2020, 15:20.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCc835e67dda5f: rpc: Clarify that block count means height excl genesis

Summary

Description of PR:

There is a common misconception that the block count returned by the blockchain rpcs includes the genesis block.
However, it really returns the height, which is 0 for the genesis block.
So clarify that and also remove the misleading "longest blockchain" comment.
Finally, fix the wallet test that incorrectly used this rpc.

Backport of Core PR16325

Test Plan

ninja && ninja check-all
src/bitcoin-cli help getbestblockhash
src/bitcoin-cli help getbockcount

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 8 2020, 15:20

Owners added a reviewer: Restricted Owners Package.Oct 8 2020, 15:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2020, 15:20

PiRK requested review of this revision.Oct 8 2020, 15:20

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

PiRK edited the test plan for this revision. (Show Details)Oct 8 2020, 15:23

Harbormaster completed remote builds in B13268: Diff 24393.Oct 8 2020, 15:28

deadalnix accepted this revision.Oct 8 2020, 15:41

deadalnix edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Oct 8 2020, 15:43

Closed by commit rABCc835e67dda5f: rpc: Clarify that block count means height excl genesis (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyOct 8 2020, 16:06

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc835e67dda5f: rpc: Clarify that block count means height excl genesis.

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

12 lines

test/

functional/

wallet_resendwallettransactions.py

3 lines

Diff 24397

View Options

src/rpc/blockchain.cpp