Merge #19756: tests: add sync_all to fix race condition in wallet groups test
ClosedPublic
Actions

Authored by jasonbcox on Oct 8 2020, 17:58.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb427253b0a2f: Merge #19756: tests: add sync_all to fix race condition in wallet groups test

Summary

72ae20fc142457a200278cb2fedc5e32a3766b58 tests: add sync_all to fix race condition in wallet groups test (Karl-Johan Alm)

Pull request description:

This most likely fixes #19749, the intermittent CI issues with wallet_groups.

This fix is also included in #19743.

Backport of Core PR19756

We're seeing increased flakiness for this test in our sanitizer builds. This should fix it.

Test Plan

./test/functional/test_runner.py wallet_groups

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Oct 8 2020, 17:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2020, 17:58

jasonbcox requested review of this revision.Oct 8 2020, 17:58

teamcity edited the summary of this revision. (Show Details)Oct 8 2020, 17:58

Fabien accepted this revision.Oct 8 2020, 18:01

This revision is now accepted and ready to land.Oct 8 2020, 18:01

This revision was landed with ongoing or failed builds.Oct 8 2020, 18:16

Closed by commit rABCb427253b0a2f: Merge #19756: tests: add sync_all to fix race condition in wallet groups test (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain Why

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCb427253b0a2f: Merge #19756: tests: add sync_all to fix race condition in wallet groups test.

Revision Contents
Changeset List

Path

Size

test/

functional/

wallet_groups.py

1 line

Diff 24409

View Options

test/functional/wallet_groups.py

Merge #19756: tests: add sync_all to fix race condition in wallet groups testClosedPublicActions