Add pubkey prefix constants to include/secp256k1.h
ClosedPublic
Actions

Authored by deadalnix on Dec 10 2017, 23:04.

Details

Reviewers

schancel
MattBitprim

Group Reviewers

Restricted Project

Commits

rSTAGING09dc40569ae3: Add pubkey prefix constants to include/secp256k1.h
rABC09dc40569ae3: Add pubkey prefix constants to include/secp256k1.h

Summary

This is backport of PR#459 by Andrew Poelstra

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 10 2017, 23:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2017, 23:04

Harbormaster completed remote builds in B1312: Diff 2031.Dec 10 2017, 23:04

schancel added inline comments.Dec 11 2017, 20:11

src/secp256k1/src/eckey_impl.h
46 ↗	(On Diff #2031)	Is `0x02 \| (secp256k1_fe_is_odd(&elem->y)` ever false? This looks like it's going to store a different value than before. cout << hex << (0x02 \| 0x00 ? 0 : 1) <<endl; Always prints 0

schancel added inline comments.Dec 11 2017, 20:12

src/secp256k1/src/eckey_impl.h
46 ↗	(On Diff #2031)	Rather, it prints `0` and not `3`

Nevermind, I didn't see some brackets.

This revision is now accepted and ready to land.Dec 11 2017, 20:13

Closed by commit rABC09dc40569ae3: Add pubkey prefix constants to include/secp256k1.h (authored by deadalnix). · Explain WhyDec 11 2017, 20:49

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

include/

secp256k1.h

7 lines

src/

eckey_impl.h

11 lines

Diff 2054

View Options

src/secp256k1/include/secp256k1.h