Fix autostart filenames on Linux
ClosedPublic
Actions

Authored by PiRK on Oct 12 2020, 07:42.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC2c3dccae4665: Fix autostart filenames on Linux

Summary

Autostart filenames on Linux must end with .desktop, not .lnk.

Backport of Core PR16379

Test Plan

ninja && src/qt/bitcoin-qt -regtest

Menu Settings -> Options -> Main, check Start Bitcoin ABC on system login
ls $HOME/.config/autostart/bitcoin-regtest.desktop

Log-out, log back in, verify that bitcoin-qt -regtest is started.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 12 2020, 07:42

Owners added a reviewer: Restricted Owners Package.Oct 12 2020, 07:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2020, 07:42

PiRK requested review of this revision.Oct 12 2020, 07:42

teamcity edited the summary of this revision. (Show Details)Oct 12 2020, 07:42

Fabien accepted this revision.Oct 12 2020, 07:45

This revision is now accepted and ready to land.Oct 12 2020, 07:45

PiRK edited the test plan for this revision. (Show Details)Oct 12 2020, 07:47

Harbormaster completed remote builds in B13358: Diff 24552.Oct 12 2020, 07:48

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[0m[1;30mwallet_hd.py                                     | ○ Skipped | 0 s
[0m[1;30mwallet_import_rescan.py                          | ○ Skipped | 0 s
[0m[1;30mwallet_import_with_label.py                      | ○ Skipped | 0 s
[0m[1;30mwallet_importmulti.py                            | ○ Skipped | 1 s
[0m[1;30mwallet_importprunedfunds.py                      | ○ Skipped | 0 s
[0m[1;30mwallet_keypool.py                                | ○ Skipped | 1 s
[0m[1;30mwallet_keypool_topup.py                          | ○ Skipped | 0 s
[0m[1;30mwallet_labels.py                                 | ○ Skipped | 0 s
[0m[1;30mwallet_listreceivedby.py                         | ○ Skipped | 0 s
[0m[1;30mwallet_listsinceblock.py                         | ○ Skipped | 0 s
[0m[1;30mwallet_listtransactions.py                       | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py                            | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py --usecli                   | ○ Skipped | 0 s
[0m[1;30mwallet_reorgsrestore.py                          | ○ Skipped | 1 s
[0m[1;30mwallet_resendwallettransactions.py               | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py                              | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py --mineblock                  | ○ Skipped | 1 s
[0m[1;30mwallet_txn_doublespend.py                        | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py --mineblock            | ○ Skipped | 1 s
[0m[1;30mwallet_watchonly.py                              | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py --usecli                     | ○ Skipped | 0 s
[0m[1;30mwallet_zapwallettxes.py                          | ○ Skipped | 1 s
[0m[0;31mrpc_bind.py                                      | ✖ Failed  | 2 s
[0m[0;31m[1m
ALL                                              | ✖ Failed  | 236 s (accumulated) 
[0m[0mRuntime: 47 s

[135/379] Running avalanche test suite
PASSED: avalanche test suite
[144/379] Running seeder test suite
PASSED: seeder test suite
[152/379] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.005s

OK
[153/379] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[161/379] Running pow test suite
PASSED: pow test suite
[168/379] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[170/379] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:541:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[378/379] Running bitcoin test suite
PASSED: bitcoin test suite
FAILED: test/CMakeFiles/check-functional 
cd /work/abc-ci-builds/build-without-wallet/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py "--testsuitename=Bitcoin ABC functional tests" --junitoutput=/work/abc-ci-builds/build-without-wallet/test/junit/functional_tests.xml
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_bind.py

PiRK edited the test plan for this revision. (Show Details)Oct 12 2020, 07:48

This revision was landed with ongoing or failed builds.Oct 12 2020, 09:06

Closed by commit rABC2c3dccae4665: Fix autostart filenames on Linux (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain Why

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2c3dccae4665: Fix autostart filenames on Linux.