[qa] Fix race condition in example_test.py
ClosedPublic
Actions

Authored by PiRK on Oct 12 2020, 10:22.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCb8eaec1a704c: [qa] Fix race condition in example_test.py

Summary

PR description:

There's a race between sending a getdata for a bunch of blocks with the node receiving those blocks from a peer, which could cause test failure. Fix this.

Motivated by observing this race caused an appveyor test failure on another PR

Backport of Core PR16459

Test Plan

ninja && test/functional/test_runner.py example_test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 12 2020, 10:22

Owners added a reviewer: Restricted Owners Package.Oct 12 2020, 10:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2020, 10:22

PiRK requested review of this revision.Oct 12 2020, 10:22

teamcity edited the summary of this revision. (Show Details)Oct 12 2020, 10:22

PiRK edited the summary of this revision. (Show Details)Oct 12 2020, 10:23

Harbormaster completed remote builds in B13359: Diff 24555.Oct 12 2020, 10:34

Fabien accepted this revision.Oct 12 2020, 11:03

This revision is now accepted and ready to land.Oct 12 2020, 11:03

Closed by commit rABCb8eaec1a704c: [qa] Fix race condition in example_test.py (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by PiRK). · Explain WhyOct 12 2020, 11:45

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb8eaec1a704c: [qa] Fix race condition in example_test.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

example_test.py

6 lines

Diff 24558

View Options

test/functional/example_test.py

[qa] Fix race condition in example_test.pyClosedPublicActions