Page MenuHomePhabricator

[backport#15801] GUI: Set the range of pruning size before loading its value
ClosedPublic

Authored by PiRK on Tue, Oct 13, 08:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC654a805e961e: [backport#15801] GUI: Set the range of pruning size before loading its value
Summary

PR description:

This fixes two bugs:

  • The prune setting range was set after loading the current value. If users had a prune of (eg) 200, it would get limited to 99 before the range was raised. This is fixed by setting the range first.
  • The prune setting was limited to <= the chainparams' "assumed blockchain size". There's no reason for this limit (the UX is the same either way), and there are use cases it breaks (eg, setting a prune size such that it begins pruning at some future point). Therefore, I raised it to the max value.

Backport of Core PR15801

Test Plan

ninja && ninja check

Build and install bitcoin-qt, check that this setting is not limited to current blockchain size.
Menu Settings -> Options -> Main -> Prune block storage to ___ Gb

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.