Page MenuHomePhabricator

Merge #16470: test: Fail early on disconnect in mininode.wait_for_*
ClosedPublic

Authored by jasonbcox on Tue, Oct 13, 23:22.

Details

Summary

fac2e6a6045e4ddd6b473f4f3ddbb69d9d6921f6 test: Fail early on disconnect in mininode.wait_for_* (MarcoFalke)

Pull request description:

The node might crash or disconnect when our mininode waits for data. Due to the crash, the data is guaranteed to never arrive and we can fail early with an assert

Backport of Core PR16470

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

test/functional/test_framework/mininode.py
537 ↗(On Diff #24607)

The left side does not match the original PR because we diverged here a long time ago. I opted to bring us more inline with Core's code even though ours reads slightly better.

This revision is now accepted and ready to land.Wed, Oct 14, 09:51