doc: Remove mention of renamed mapBlocksUnlinked
ClosedPublic
Actions

Authored by PiRK on Oct 19 2020, 08:46.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC113ee003dbd0: doc: Remove mention of renamed mapBlocksUnlinked

Summary

This has been renamed to m_blocks_unlinked. Instead of adjusting the internal variable name in the help text, explain the debug flag with more general terms.

Backport of Core PR17001

Test Plan

ninja && src/bitcoind -help-debug

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 19 2020, 08:46

Owners added a reviewer: Restricted Owners Package.Oct 19 2020, 08:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2020, 08:46

PiRK requested review of this revision.Oct 19 2020, 08:46

teamcity edited the summary of this revision. (Show Details)Oct 19 2020, 08:46

Harbormaster completed remote builds in B13484: Diff 24774.Oct 19 2020, 08:51

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[323/379] bitcoin: testing torcontrol_tests
[324/379] Running utility command for check-bitcoin-torcontrol_tests
[325/379] bitcoin: testing timedata_tests
[326/379] bitcoin: testing settings_tests
[327/379] Running utility command for check-bitcoin-timedata_tests
[328/379] Running utility command for check-bitcoin-settings_tests
[329/379] bitcoin: testing undo_tests
[330/379] bitcoin: testing uint256_tests
[331/379] Running utility command for check-bitcoin-undo_tests
[332/379] Running utility command for check-bitcoin-uint256_tests
[333/379] bitcoin: testing util_threadnames_tests
[334/379] Running utility command for check-bitcoin-util_threadnames_tests
[335/379] bitcoin: testing compilerbug_tests
[336/379] Running utility command for check-bitcoin-compilerbug_tests
[337/379] bitcoin: testing checkpoints_tests
[338/379] bitcoin: testing serialize_tests
[339/379] bitcoin: testing sigencoding_tests
[340/379] Running utility command for check-bitcoin-checkpoints_tests
[341/379] Running utility command for check-bitcoin-serialize_tests
[342/379] Running utility command for check-bitcoin-sigencoding_tests
[343/379] bitcoin: testing validationinterface_tests
[344/379] Running utility command for check-bitcoin-validationinterface_tests
[345/379] bitcoin: testing txvalidationcache_tests
[346/379] Running utility command for check-bitcoin-txvalidationcache_tests
[347/379] bitcoin: testing script_standard_tests
[348/379] Running utility command for check-bitcoin-script_standard_tests
[349/379] bitcoin: testing cashaddr_tests
[350/379] Running utility command for check-bitcoin-cashaddr_tests
[351/379] bitcoin: testing radix_tests
[352/379] Running utility command for check-bitcoin-radix_tests
[353/379] bitcoin: testing getarg_tests
[354/379] Running utility command for check-bitcoin-getarg_tests
[355/379] bitcoin: testing versionbits_tests
[356/379] bitcoin: testing crypto_tests
[357/379] Running utility command for check-bitcoin-versionbits_tests
[358/379] Running utility command for check-bitcoin-crypto_tests
[359/379] bitcoin: testing blockcheck_tests
[360/379] Running utility command for check-bitcoin-blockcheck_tests
[361/379] bitcoin: testing monolith_opcodes_tests
[362/379] bitcoin: testing script_tests
[363/379] bitcoin: testing validation_tests
[364/379] Running utility command for check-bitcoin-monolith_opcodes_tests
[365/379] Running utility command for check-bitcoin-script_tests
[366/379] Running utility command for check-bitcoin-validation_tests
[367/379] bitcoin: testing validation_block_tests
[368/379] Running utility command for check-bitcoin-validation_block_tests
[369/379] bitcoin: testing cuckoocache_tests
[370/379] Running utility command for check-bitcoin-cuckoocache_tests
[371/379] bitcoin: testing util_tests
[372/379] Running utility command for check-bitcoin-util_tests
[373/379] bitcoin: testing op_reversebytes_tests
[374/379] Running utility command for check-bitcoin-op_reversebytes_tests
[375/379] bitcoin: testing transaction_tests
[376/379] Running utility command for check-bitcoin-transaction_tests
[377/379] bitcoin: testing coins_tests
[378/379] Running utility command for check-bitcoin-coins_tests
[379/379] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_blocksonly.py

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[0m[0;32mrpc_getblockstats.py                             | ✓ Passed  | 1 s
[0m[0;32mrpc_getchaintips.py                              | ✓ Passed  | 2 s
[0m[0;32mrpc_help.py                                      | ✓ Passed  | 1 s
[0m[0;32mrpc_invalidateblock.py                           | ✓ Passed  | 6 s
[0m[0;32mrpc_misc.py                                      | ✓ Passed  | 1 s
[0m[0;32mrpc_named_arguments.py                           | ✓ Passed  | 1 s
[0m[0;32mrpc_net.py                                       | ✓ Passed  | 1 s
[0m[0;32mrpc_preciousblock.py                             | ✓ Passed  | 1 s
[0m[0;32mrpc_psbt.py                                      | ✓ Passed  | 20 s
[0m[0;32mrpc_rawtransaction.py                            | ✓ Passed  | 56 s
[0m[0;32mrpc_scantxoutset.py                              | ✓ Passed  | 4 s
[0m[0;32mrpc_setban.py                                    | ✓ Passed  | 2 s
[0m[0;32mrpc_signmessage.py                               | ✓ Passed  | 1 s
[0m[0;32mrpc_signrawtransaction.py                        | ✓ Passed  | 1 s
[0m[0;32mrpc_txoutproof.py                                | ✓ Passed  | 2 s
[0m[0;32mrpc_uptime.py                                    | ✓ Passed  | 1 s
[0m[0;32mrpc_users.py                                     | ✓ Passed  | 5 s
[0m[0;32mrpc_whitelist.py                                 | ✓ Passed  | 1 s
[0m[0;32mtool_wallet.py                                   | ✓ Passed  | 3 s
[0m[0;32mwallet_abandonconflict.py                        | ✓ Passed  | 8 s
[0m[0;32mwallet_address_types.py                          | ✓ Passed  | 18 s
[0m[0;32mwallet_avoidreuse.py                             | ✓ Passed  | 5 s
[0m[0;32mwallet_backup.py                                 | ✓ Passed  | 43 s
[0m[0;32mwallet_balance.py                                | ✓ Passed  | 15 s
[0m[0;32mwallet_basic.py                                  | ✓ Passed  | 26 s
[0m[0;32mwallet_coinbase_category.py                      | ✓ Passed  | 1 s
[0m[0;32mwallet_create_tx.py                              | ✓ Passed  | 5 s
[0m[0;32mwallet_createwallet.py                           | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --usecli                  | ✓ Passed  | 3 s
[0m[0;32mwallet_disable.py                                | ✓ Passed  | 1 s
[0m[0;32mwallet_dump.py                                   | ✓ Passed  | 2 s
[0m[0;32mwallet_encryption.py                             | ✓ Passed  | 5 s
[0m[0;32mwallet_groups.py                                 | ✓ Passed  | 35 s
[0m[0;32mwallet_hd.py                                     | ✓ Passed  | 5 s
[0m[0;32mwallet_import_rescan.py                          | ✓ Passed  | 5 s
[0m[0;32mwallet_import_with_label.py                      | ✓ Passed  | 1 s
[0m[0;32mwallet_importmulti.py                            | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py                      | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                                | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                          | ✓ Passed  | 3 s
[0m[0;32mwallet_labels.py                                 | ✓ Passed  | 1 s
[0m[0;32mwallet_listreceivedby.py                         | ✓ Passed  | 11 s
[0m[0;32mwallet_listsinceblock.py                         | ✓ Passed  | 2 s
[0m[0;32mwallet_listtransactions.py                       | ✓ Passed  | 17 s
[0m[0;32mwallet_multiwallet.py                            | ✓ Passed  | 14 s
[0m[0;32mwallet_multiwallet.py --usecli                   | ✓ Passed  | 14 s
[0m[0;32mwallet_reorgsrestore.py                          | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py               | ✓ Passed  | 9 s
[0m[0;32mwallet_txn_clone.py                              | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_clone.py --mineblock                  | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py                        | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_doublespend.py --mineblock            | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                              | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli                     | ✓ Passed  | 1 s
[0m[0;32mwallet_zapwallettxes.py                          | ✓ Passed  | 5 s
[0m[1m
ALL                                              | ✓ Passed  | 753 s (accumulated) 
[0mRuntime: 151 s

Build build-diff timed out after 1200.0s

Fabien accepted this revision.Oct 19 2020, 09:50

This revision is now accepted and ready to land.Oct 19 2020, 09:50

rebase

Harbormaster completed remote builds in B13489: Diff 24783.Oct 19 2020, 12:17

Closed by commit rABC113ee003dbd0: doc: Remove mention of renamed mapBlocksUnlinked (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyOct 19 2020, 15:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC113ee003dbd0: doc: Remove mention of renamed mapBlocksUnlinked.