The address associated with a receive request is encoded using the
configuration of the client at the time. This can be either base58 or
cashaddr.
When displaying an existing receive request, display with the currently
configured encoding.
Details
Details
- Reviewers
dagurval - Group Reviewers
Restricted Project - Commits
- rSTAGINGf3cc32abad43: Use user configured encoding in receive request
rABCf3cc32abad43: Use user configured encoding in receive request
- Added test.
- Create two requests, one running with -usecashaddr and one without.
- Start client with and without -usercashaddr, observe that requests are displayed correct.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/qt/receiverequestdialog.cpp | ||
|---|---|---|
| 115 ↗ | (On Diff #2108) | Why do we return what we have as input when the input is invalid ? Is it a desired behavior ? |
| src/qt/test/guiutiltests.cpp | ||
| 14 ↗ | (On Diff #2108) | UtilDummyConfig We don't want to have random word swapping and/or shortening in all parts of the codebase. |
| 46 ↗ | (On Diff #2108) | config |
| src/qt/receiverequestdialog.cpp | ||
|---|---|---|
| 115 ↗ | (On Diff #2108) | Because basically that's what we did before. Just displayed it. I don't know what cruft could be in the database or if adresses were stored differently somehow. This is also not really the right place to validate, that should be done when reading from the database. I don't know what state the qt client goes into if we throw here. An alternative is also to just to return an empty string. Suggestions? |