doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util
ClosedPublic
Actions

Authored by PiRK on Oct 22 2020, 11:53.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC96c54d32f217: doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util

Summary

The param coins to SignTransaction is final and can thus not be extended (as suggested by the doc).
This was changed in PR16798 where ParsePrevouts was extracted from SignTransaction.

This is a backport of Core PR16900

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 22 2020, 11:53

Owners added a reviewer: Restricted Owners Package.Oct 22 2020, 11:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2020, 11:53

PiRK requested review of this revision.Oct 22 2020, 11:53

teamcity edited the summary of this revision. (Show Details)Oct 22 2020, 11:54

deadalnix accepted this revision.Oct 22 2020, 12:01

This revision is now accepted and ready to land.Oct 22 2020, 12:01

Harbormaster completed remote builds in B13594: Diff 24944.Oct 22 2020, 12:05

Closed by commit rABC96c54d32f217: doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyOct 22 2020, 14:00

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC96c54d32f217: doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util.

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction_util.h

7 lines

rawtransaction_util.cpp

4 lines

Diff 24948

View Options

src/rpc/rawtransaction_util.h