Page MenuHomePhabricator
Differential D8060

[build-bot] Fix database test when an extension is not present on the database file
ClosedPublic
Actions

Authored by jasonbcox on Oct 22 2020, 17:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC47e2944da10c: [build-bot] Fix database test when an extension is not present on the database…
Summary

In some versions of Python, a different database backend may be selected.
The backend selected may or may not append an extension to the database file.

This patch fixes the implementation and test to work whether a file extension is present
or not. It also moves the test database to a more predictable location and does not
clean it up after the test is run to allow for easier post-test debugging.

Test Plan
Running `pytest` in either `contrib/buildbot` or `contrib/buildbot/test` produces
`contrib/buildbot/test/test_output/database`(with optional `.db` extension).
Running `pytest` repeatedly, the tests still pass.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Oct 22 2020, 17:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2020, 17:05
jasonbcox requested review of this revision.Oct 22 2020, 17:05
Harbormaster completed remote builds in B13602: Diff 24957.Oct 22 2020, 17:26
Fabien accepted this revision.Oct 22 2020, 20:11
Fabien added a subscriber: Fabien.

Tested working no my environment which adds no extension to the db file

This revision is now accepted and ready to land.Oct 22 2020, 20:11
Closed by commit rABC47e2944da10c: [build-bot] Fix database test when an extension is not present on the database… (authored by jasonbcox). · Explain WhyOct 22 2020, 21:25
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC47e2944da10c: [build-bot] Fix database test when an extension is not present on the database….

Revision Contents
Changeset List

PathSize
contrib/
buildbot/
13 lines
test/
1 line
5 lines
17 lines

Diff 24977

View Options

contrib/buildbot/server.py

Loading...
View Options

contrib/buildbot/test/.gitignore

Loading...
View Options

contrib/buildbot/test/abcbot_fixture.py

Loading...
View Options

contrib/buildbot/test/test_persist_database.py

Loading...