Page MenuHomePhabricator
Differential D8076

gui: show watch-only balance in send screen
ClosedPublic
Actions

Authored by deadalnix on Oct 23 2020, 12:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa690e66ad2c1: gui: show watch-only balance in send screen
Summary
  • [test] qt: add send screen balance test
  • [gui] send: show watch-only balance in send screen

This is a backport of Core PR17587

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 23 2020, 12:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2020, 12:16
deadalnix requested review of this revision.Oct 23 2020, 12:16
teamcity edited the summary of this revision. (Show Details)Oct 23 2020, 12:17
Harbormaster completed remote builds in B13625: Diff 25009.Oct 23 2020, 12:25
Fabien accepted this revision.Oct 23 2020, 12:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/test/wallettests.cpp
153 ↗(On Diff #25009)

You should move the line after RemoveWallet to keep it closer to core

This revision is now accepted and ready to land.Oct 23 2020, 12:50
Closed by commit rABCa690e66ad2c1: gui: show watch-only balance in send screen (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by deadalnix). · Explain WhyOct 23 2020, 13:09
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCa690e66ad2c1: gui: show watch-only balance in send screen.

Revision Contents
Changeset List

PathSize
src/
qt/
forms/
2 lines
7 lines
test/
14 lines

Diff 25015

View Options

src/qt/forms/sendcoinsdialog.ui

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...