Differential D8180

[bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly addresses
ClosedPublic
Actions

Authored by majcosta on Oct 29 2020, 17:12.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC1dd3de23870b: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly…

Summary

73041c3c99 RPC Docs: addmultisigaddress is intended for non-watchonly addresses (Gregory Sanders)

Pull request description:

Spent a couple hours debugging why my p2sh watchonly funds were not appearing in various accounting calls when address was imported via `addmultisigaddress`.

Backport of Core PR10677

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 29 2020, 17:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2020, 17:12

majcosta requested review of this revision.Oct 29 2020, 17:12

teamcity edited the summary of this revision. (Show Details)Oct 29 2020, 17:12

Harbormaster completed remote builds in B13749: Diff 25239.Oct 29 2020, 17:45

jasonbcox accepted this revision.Oct 29 2020, 18:09

This revision is now accepted and ready to land.Oct 29 2020, 18:09

Closed by commit rABC1dd3de23870b: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly… (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyOct 29 2020, 18:48

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC1dd3de23870b: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly….

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

3 lines

Diff 25248

View Options

[bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly addressesClosedPublicActions